feat: Add kfp-tensorflow notebook to confirm NVIDIA GPU access #139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add `kfp-tensorflow` notebook in order to confirm access to a GPU. The notebook spins uses kfp SDK to create an experiment and a run that succeeds when: * the run's pod is scheduled on a node with an NVIDIA GPU * the run's code, and more specifically Tensorflow framework, has access to an NVIDIA GPU.
orfeas-k
force-pushed
the
kf-6358-uats-scenario
branch
from
2b5008e
to
af73b9b
Compare
kimwnasptd
requested changes
Nov 28, 2024
There was a problem hiding this comment.
Works as expected!
Wanted to try and force TensorFlow to go on the GPU with tf.config.set_visible_devices([], 'CPU') but I ended up getting the error:
NotFoundError: No CPU devices are available in this process
So we'll have to stick with listing visible devices, which should be fine
tests/notebooks/gpu/kfp-tensorflow/kfp-tensorflow-integration.ipynb
Outdated
Show resolved
Hide resolved
tests/notebooks/gpu/kfp-tensorflow/kfp-tensorflow-integration.ipynb
Outdated
Show resolved
Hide resolved
|
@kimwnasptd Updated according to comments + pushed a commit to remove the placeholder notebook. |
kimwnasptd
approved these changes
Nov 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
kfp-tensorflownotebook in order to confirm access to a GPU. The notebook spins uses kfp SDK to create an experiment and a run that succeeds when:Closes #128
Testing
Similar to #138, in order to test the PR
--include-gpu-testsflag e.g.