Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: configure the UATs to run behind a proxy using Notebooks #98

Merged
merged 15 commits into from
Aug 20, 2024
Merged

feat: configure the UATs to run behind a proxy using Notebooks #98

merged 15 commits into from
Aug 20, 2024

Conversation

NohaIhab
Copy link
Contributor

@NohaIhab NohaIhab commented Aug 2, 2024 •
edited
Loading

closes #95

Summary

Configures the UATs for the following components to run behind Proxy:

  • Katib
  • Training Operator
  • Pipelines

Note to reviewer

orfeas-k
orfeas-k reviewed Aug 5, 2024
View reviewed changes
Copy link
Contributor

@orfeas-k orfeas-k left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments. Regarding training-integration notebook, could we avoid refactoring because right now I can't check the differences. I 'd also ref #76 since this where the solution has been designed in theory.

tests/README.md Outdated Show resolved Hide resolved
tests/README.md Outdated Show resolved Hide resolved
tests/README.md Outdated Show resolved Hide resolved
tests/README.md Outdated Show resolved Hide resolved
tests/notebooks/kfp_v2/kfp-v2-integration.ipynb Show resolved Hide resolved
DnPlas
DnPlas reviewed Aug 16, 2024
View reviewed changes
Copy link
Contributor

@DnPlas DnPlas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @NohaIhab, left some comments.

tests/notebooks/katib/katib-integration.ipynb Show resolved Hide resolved
tests/notebooks/katib/katib-integration.ipynb Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
DnPlas
DnPlas reviewed Aug 16, 2024
View reviewed changes
README.md Outdated Show resolved Hide resolved
@DnPlas DnPlas mentioned this pull request Aug 19, 2024
Merged
DnPlas
DnPlas reviewed Aug 19, 2024
View reviewed changes
Copy link
Contributor

@DnPlas DnPlas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a tiny comment, other than that LGTM

README.md Outdated Show resolved Hide resolved
@NohaIhab NohaIhab changed the base branch from main to KF-5945-configure-proxy-dev-branch August 20, 2024 14:37
DnPlas
DnPlas approved these changes Aug 20, 2024
View reviewed changes
Copy link
Contributor

@DnPlas DnPlas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @NohaIhab, LGTM!

@NohaIhab NohaIhab merged commit d8f63ea into KF-5945-configure-proxy-dev-branch Aug 20, 2024
1 check passed
@NohaIhab NohaIhab deleted the kf-6028-feat-configure-notebooks-with-proxy branch August 20, 2024 14:41
@NohaIhab NohaIhab mentioned this pull request Aug 21, 2024
Closed
@DnPlas DnPlas mentioned this pull request Aug 23, 2024
Merged
DnPlas added a commit that referenced this pull request Aug 28, 2024
@DnPlas
Merge KF-5945-configure-proxy-dev-branch into main (#106)
b40dfb3 
This commit merges `KF-5945-configure-proxy-dev-branch` into `main` to
support the proxy configuration for UATs.

* #98
* #105
* #103
* #111

Fixes #75
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orfeas-k orfeas-k orfeas-k left review comments

@DnPlas DnPlas DnPlas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Running using Notebook: Configure the UATs to run behind a proxy
3 participants
@NohaIhab @DnPlas @orfeas-k