Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: configure proxy env vars storage init container #257

Merged
merged 7 commits into from
Aug 5, 2024

Conversation

NohaIhab
Copy link
Contributor

part of canonical/knative-operators#204

Summary

Adds charm configs to kserve-controller charm to enable configuring the proxy environment variables in the storage-initializer init container of InferenceService Pod. It is done by modifying the ClusterStorageContainer CR, for more info see the KServe docs.

This change will enable CKF users to use KServe behind a proxy.

Copy link
Contributor

@orfeas-k orfeas-k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job! Left some comments regarding tets.

charms/kserve-controller/tests/integration/test_charm.py Outdated Show resolved Hide resolved
charms/kserve-controller/tests/integration/test_charm.py Outdated Show resolved Hide resolved
charms/kserve-controller/tests/integration/test_charm.py Outdated Show resolved Hide resolved
Copy link
Contributor

@orfeas-k orfeas-k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!

@NohaIhab NohaIhab merged commit 6021cca into main Aug 5, 2024
7 checks passed
@NohaIhab NohaIhab deleted the kf-6041-fix-configure-proxy-env-vars-storage-init branch August 5, 2024 10:53
NohaIhab added a commit that referenced this pull request Aug 19, 2024
* fix: add configs for proxy envs in storage-initializer container
* add integration test
* fix: config description
* refactor serverless namespace fixture
* refactor common sklearn example
NohaIhab added a commit that referenced this pull request Aug 19, 2024
* fix: add configs for proxy envs in storage-initializer container
* add integration test
* fix: config description
* refactor serverless namespace fixture
* refactor common sklearn example
NohaIhab added a commit that referenced this pull request Aug 20, 2024
…-env-vars-storage-init-0.11

(cherry-pick to track/0.11) fix: configure proxy env vars storage init container (#257)
NohaIhab added a commit that referenced this pull request Aug 21, 2024
…-env-vars-storage-init-0.13

(cherry-pick to track/0.13) fix: configure proxy env vars storage init container (#257)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants