-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: configure proxy env vars storage init container #257
Merged
NohaIhab
merged 7 commits into
main
from
kf-6041-fix-configure-proxy-env-vars-storage-init
Aug 5, 2024
Merged
fix: configure proxy env vars storage init container #257
NohaIhab
merged 7 commits into
main
from
kf-6041-fix-configure-proxy-env-vars-storage-init
Aug 5, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
orfeas-k
reviewed
Aug 1, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job! Left some comments regarding tets.
orfeas-k
approved these changes
Aug 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job!
NohaIhab
added a commit
that referenced
this pull request
Aug 19, 2024
* fix: add configs for proxy envs in storage-initializer container * add integration test * fix: config description * refactor serverless namespace fixture * refactor common sklearn example
NohaIhab
added a commit
that referenced
this pull request
Aug 19, 2024
* fix: add configs for proxy envs in storage-initializer container * add integration test * fix: config description * refactor serverless namespace fixture * refactor common sklearn example
This was referenced Aug 19, 2024
NohaIhab
added a commit
that referenced
this pull request
Aug 20, 2024
…-env-vars-storage-init-0.11 (cherry-pick to track/0.11) fix: configure proxy env vars storage init container (#257)
NohaIhab
added a commit
that referenced
this pull request
Aug 21, 2024
…-env-vars-storage-init-0.13 (cherry-pick to track/0.13) fix: configure proxy env vars storage init container (#257)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
part of canonical/knative-operators#204
Summary
Adds charm configs to
kserve-controller
charm to enable configuring the proxy environment variables in thestorage-initializer
init container of InferenceService Pod. It is done by modifying theClusterStorageContainer
CR, for more info see the KServe docs.This change will enable CKF users to use KServe behind a proxy.