chore(merge): merge '2.9.0' into 'main' #376
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>
Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>
The correct location to add craft-parts Features is a bit tricky: - it must happen soon enough that things that happen early have the correct features enabled. For example, building the default command groups takes into account whether overlays are enabled; - it must happen late enough that the craft-cli logging support has already been set-up. Therefore, provide a method that Application subclasses can override to enable their features, and the Application itself takes care of calling it at the correct time.
The (new) rule is this: in validators, always raise the types that Pydantic expects (ValueErrors, AssertionErrors, TypeError, and subclasses of these). This allows Pydantic to capture all errors and group them into a single ValidationError, which we can then convert into a single CraftValidationError in from_yaml_data(). This provides a more uniform UI for the reporting of validation errors on the project.
Ensure that each error message starts with a lowercase letter.
This way the validation errors get correctly translated and converted into CraftValidationErrors.
This is mainly used for validation errors: when a CraftBaseModel fails to be created due to Pydantic validation errors, the link to that specific model class is added to the error message shown to the user.
Signed-off-by: Claudio Matsuoka <claudio.matsuoka@canonical.com>
Now that the 'rockcraft' work branch has been merged and released we can fix the version constraint for craft-cli and craft-parts.
This workflow is similar to starbase's current one, with a few differences: - It uses self-hosted runners; - It uses Trusted Publishers to publish to PyPI; - It constrains the artifacts that are attached to the GH release.
This is a partial revert of 0115c28; apparently actions/checkout's "fetch-tags" property is broken and gives errors at checkout time. Ref: actions/checkout#1467
tigarmo
changed the title
mr-cal
approved these changes
Jul 5, 2024
3 tasks
|
I landed #373 without thinking about this being staged, sorry for forcing you to redo this merge. |
dariuszd21
approved these changes
Jul 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tox?