Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(remotebuild): add property for launchpad credentials filepath #373

Merged
merged 1 commit into from
Jul 5, 2024
Merged

feat(remotebuild): add property for launchpad credentials filepath #373

merged 1 commit into from
Jul 5, 2024

Conversation

mr-cal
Copy link
Contributor

@mr-cal mr-cal commented Jul 3, 2024 •
edited
Loading

  • Have you followed the guidelines for contributing?
  • Have you signed the CLA?
  • Have you successfully run tox?

Adds a credentials_filepath property so applications can point to a different credentials file.

Unblocks canonical/snapcraft#4889
Unblocks canonical/snapcraft#4892
(CRAFT-3077)

@mr-cal
feat(remotebuild): add property for launchpad credentials filepath
0f3d921 
Signed-off-by: Callahan Kovacs <callahankovacs@gmail.com>
@mr-cal mr-cal mentioned this pull request Jul 3, 2024
Merged
4 tasks
@sergiusens sergiusens requested a review from lengau July 3, 2024 21:17
@mr-cal mr-cal merged commit 7bd798e into main Jul 5, 2024
6 checks passed
@mr-cal mr-cal deleted the work/CRAFT-3077/launchpad-credentials branch July 5, 2024 12:59
@mr-cal mr-cal mentioned this pull request Jul 5, 2024
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tigarmo tigarmo tigarmo approved these changes

@sergiusens sergiusens sergiusens approved these changes

@lengau lengau Awaiting requested review from lengau

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mr-cal @sergiusens @tigarmo