fix(remotebuild): use legacy launchpad credentials if they exist #4892
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
3 tasks
mr-cal
force-pushed
the
work/CRAFT-3077/launchpad-credentials
branch
from
38881f9
to
628b00f
Compare
tigarmo
reviewed
Jul 4, 2024
3 tasks
|
Tests will fail until craft-application 3.1.0 gets out the door |
4 tasks
tigarmo
approved these changes
Jul 5, 2024
If the legacy remote-build credentials exist and the new credentials do not, emit a deprecation warning and use the legacy credentials. Signed-off-by: Callahan Kovacs <callahan.kovacs@canonical.com>
Signed-off-by: Callahan Kovacs <callahan.kovacs@canonical.com>
Signed-off-by: Callahan Kovacs <callahan.kovacs@canonical.com>
mr-cal
force-pushed
the
work/CRAFT-3077/launchpad-credentials
branch
from
debe5b4
to
0c5cf46
Compare
|
Force-pushed in prep for a rebase |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tox run -m lint?tox run -e test-py310? (supported versions:py39,py310,py311,py312)Changes:
build-for: [all]in the new remote builderplatformsandarchitecturedefinitionsCI job for remote build spread tests: https://github.com/canonical/snapcraft/actions/runs/9784405987
Depends on canonical/craft-application#373
Fixes #4889
(CRAFT-3077)