Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

selenium: Replace Chrome Webdriver with Firefox #151

Open
phoevos opened this issue Aug 3, 2023 · 1 comment
Open

selenium: Replace Chrome Webdriver with Firefox #151

phoevos opened this issue Aug 3, 2023 · 1 comment
Labels
bug Something isn't working

Comments

@phoevos
Copy link
Contributor

phoevos commented Aug 3, 2023

The integration tests are currently using the Chrome driver for selenium.

We have seen our CI fail due to issues with this driver:

selenium.common.exceptions.WebDriverException: Message: unknown error: no chrome binary at /opt/google/chrome/google-chrome

This is most probably what's causing the integration tests to fail:

WARNING  selenium.webdriver.common.selenium_manager:selenium_manager.py:133 The chromedriver version (115.0.5790.110) detected in PATH at /usr/bin/chromedriver might not be compatible with the detected chrome version (115.0.5790.170); currently, chromedriver 115.0.5790.170 is recommended for chrome 115.*, so it is advised to delete the driver in PATH and retry

Goal

Replace the Chrome driver with Firefox, which is OSS, as well as the default browser in Ubuntu.
Note that this is what we're already using for the bundle-kubeflow tests.
@phoevos phoevos mentioned this issue Aug 3, 2023
Merged
@orfeas-k orfeas-k mentioned this issue Aug 7, 2023
Merged
orfeas-k added a commit that referenced this issue Aug 7, 2023
@orfeas-k
requirements: Pin selenium to 4.10.x
8e15471 
Pinning to 4.10.x because upgrading to 4.11.2 results in chrome version
compatibility issue
See #151.
orfeas-k added a commit that referenced this issue Aug 7, 2023
@orfeas-k
requirements: Pin selenium to <4.11
0a5b1c0 
Pinning to <4.11 because upgrading to 4.11.2 results in chrome version
compatibility issue.
See #151.
orfeas-k added a commit that referenced this issue Aug 7, 2023
@orfeas-k
requirements: Pin selenium to <4.11 (#156)
77dbc63 
Pinning to <4.11 because upgrading to 4.11.2 results in chrome version compatibility issue. See #151.
@orfeas-k orfeas-k added the bug Something isn't working label Aug 8, 2023
@orfeas-k
Copy link
Contributor

orfeas-k commented Aug 9, 2023

Workaround

A workaround to the chrome compatibility issue is to pin selenium<4.11 as we did in #156.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@orfeas-k @phoevos