-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Remove apt-install from Dex Charm #148
Conversation
@beliaev-maksim you approved the PR within 4 mins after it was created, and even before the tests were finished. When did you have the time to test and be sure the PR is OK? 😄 |
@kimwnasptd PR changes are fine. If CI is red then it automatically assumes that it should not be merged :) |
I believe this is what's causing the integration tests to fail:
Because then this is the exception raised:
|
@phoevos switch to firefox |
I opened an issue for switching to Firefox, I'm not sure at the moment how much effort that requires: |
Currently, Dex Charm is doing apt install. Update this logic to ensure the Dex Charm can work in an airgapped environment. Signed-off-by: Phoevos Kalemkeris <phoevos.kalemkeris@canonical.com>
3de81c3
to
0a0215f
Compare
Looks like the webdriver issue resolved itself, so this is again up for review🎉 |
@phoevos @beliaev-maksim to confirm. Do we verify now that the Charm works in airgapped environment since it doesn't do apt-install? Did you try this as well as part of the review? |
@kimwnasptd I believe airgapped should be tested as separate task, since there could be other pieces that will not work |
Currently, Dex Charm is doing apt install. Update this logic to ensure the Dex Charm can work in an airgapped environment. Closes #100 Signed-off-by: Phoevos Kalemkeris <phoevos.kalemkeris@canonical.com>
Currently, Dex Charm is doing apt install. Update this logic to ensure the Dex Charm can work in an air-gapped environment
Closes #100