Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DPE-6138] Update zookeeper client lib #157

Merged
merged 6 commits into from
Dec 11, 2024
Merged

[DPE-6138] Update zookeeper client lib #157

merged 6 commits into from
Dec 11, 2024

Conversation

Batalex
Copy link
Contributor

@Batalex Batalex commented Dec 3, 2024

Fix incompatibility with ZK when we added the expose-external configuration option. We were not properly following the zookeeper-client relation interface as well.

I had to make codespell ignore docs/ because it does not like "AKS". It should be vale's job anyway

Used in upgrade integration test
@Batalex Batalex force-pushed the zk-expose-external branch from 451432a to c6757c5 Compare December 3, 2024 14:39
@Batalex Batalex marked this pull request as ready for review December 4, 2024 17:11
src/core/models.py Outdated Show resolved Hide resolved
@Batalex Batalex merged commit 9247845 into main Dec 11, 2024
18 of 19 checks passed
@Batalex Batalex deleted the zk-expose-external branch December 11, 2024 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants