Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DPE-6138] Update zookeeper client lib #282

Merged
merged 7 commits into from
Dec 11, 2024
Merged

[DPE-6138] Update zookeeper client lib #282

merged 7 commits into from
Dec 11, 2024

Conversation

Batalex
Copy link
Contributor

@Batalex Batalex commented Dec 3, 2024 •
edited
Loading

@Batalex Batalex self-assigned this Dec 3, 2024
@Batalex Batalex marked this pull request as ready for review December 10, 2024 10:54
@imanenami
Copy link
Contributor

imanenami commented Dec 10, 2024 •
edited
Loading

Looks great, thanks!

@Batalex Batalex requested a review from deusebio December 10, 2024 14:10
deusebio
deusebio approved these changes Dec 11, 2024
View reviewed changes
Copy link
Contributor

@deusebio deusebio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

A big praise for improving the typing!

@Batalex Batalex merged commit 1c6b435 into main Dec 11, 2024
8 checks passed
@Batalex Batalex deleted the zk-expose-external branch December 11, 2024 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deusebio deusebio deusebio approved these changes

@imanenami imanenami imanenami approved these changes

@phvalguima phvalguima Awaiting requested review from phvalguima

Assignees

@Batalex Batalex

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Batalex @imanenami @deusebio