-
Notifications
You must be signed in to change notification settings - Fork 930
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ceph RBD: Restore the filesystems UUID on the volume #12745
Conversation
Ceph RBD snapshots are a read-only logical copy of the parent volume. Rewriting the filesystems UUID on the snapshot itself fails. Signed-off-by: Julian Pelizäus <julian.pelizaeus@canonical.com>
e39e924
to
d9fcc2b
Compare
Signed-off-by: Julian Pelizäus <julian.pelizaeus@canonical.com>
d9fcc2b
to
53e017a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good and I'll merge this as its a vast improvement on whats there now.
However if you take a look at the LVM driver for this same functionality, it moves the target volume to a temporary name before restoring the snapshot to the target volume name so that if any of the restore or uuid regeneration steps fail it can delete the partially restored volume, swap the old target volume back and not leave the target volume in an corrupted state.
Is this something we can do with the ceph driver too?
Thanks, I'll add a note. Especially the |
Lands fixes from: canonical/lxd#12745 canonical/lxd#12777 canonical/lxd#12805 (partial) Signed-off-by: Thomas Parrott <thomas.parrott@canonical.com>
Ceph RBD snapshots are a read-only logical copy of the parent volume. Rewriting the filesystems UUID on the snapshot itself fails.
That was observed in #12743
Fixes #12744