Ceph RBD: Regenerate the FS UUID for filesystem volumes only #12805
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Actual type block volumes may contain the block.filesystem config key which will trigger the UUID regneration. Signed-off-by: Julian Pelizäus <julian.pelizaeus@canonical.com>
|
Looks like the GH runners dont like the xfs filesystem option ...maybe we need to install the xfs tooling? |
|
xfsprogs |
roosterfish
force-pushed
the
fix_ceph_fs_uuid_restore
branch
from
40b674b
to
c2cbf05
Compare
There was already a check for all the drivers except LVM and Ceph that didn't allow setting |
tomponline
reviewed
Feb 1, 2024
…umes Signed-off-by: Julian Pelizäus <julian.pelizaeus@canonical.com>
Signed-off-by: Julian Pelizäus <julian.pelizaeus@canonical.com>
Signed-off-by: Julian Pelizäus <julian.pelizaeus@canonical.com>
Signed-off-by: Julian Pelizäus <julian.pelizaeus@canonical.com>
roosterfish
force-pushed
the
fix_ceph_fs_uuid_restore
branch
from
c2cbf05
to
8af2754
Compare
tomponline
approved these changes
Feb 1, 2024
tomponline
added a commit
to tomponline/lxd-pkg-snap
that referenced
this pull request
Feb 1, 2024
Lands fixes from: canonical/lxd#12745 canonical/lxd#12777 canonical/lxd#12805 (partial) Signed-off-by: Thomas Parrott <thomas.parrott@canonical.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #12743 (comment)
Due to #12745 that issue didn't surface.