Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makefile: Removes unnecessary pins of go deps #12794

Merged
merged 2 commits into from
Jan 30, 2024

Conversation

tomponline
Copy link
Member

No description provided.

Signed-off-by: Thomas Parrott <thomas.parrott@canonical.com>
Signed-off-by: Thomas Parrott <thomas.parrott@canonical.com>
@tomponline tomponline self-assigned this Jan 30, 2024
@tomponline tomponline marked this pull request as ready for review January 30, 2024 16:45
@tomponline tomponline merged commit 699e59c into canonical:main Jan 30, 2024
25 checks passed
@simondeziel
Copy link
Member

simondeziel commented Jan 30, 2024

Dunno how it worked for you cause here make update-gomod now fails:

$ make update-gomod 
go get -t -v -d -u ./...
go: upgraded go 1.20 => 1.21
go: added toolchain go1.21.6
go mod tidy --go=1.20
go: github.com/mdlayher/socket@v0.5.0 requires go@1.21, but 1.20 is requested
make: *** [Makefile:95: update-gomod] Error 1

@tomponline
Copy link
Member Author

ok ill revert

@tomponline
Copy link
Member Author

weird it builds ok though

@tomponline
Copy link
Member Author

im not so sure about reverting, ive tried this with go version 1.19 and 1.20 respectively locally and done a full update and build and its fine. I've confirmed the issue occurs if you try make update-gomod with go >= 1.21

@tomponline
Copy link
Member Author

I'll revert the stable-5.0 one and leave this one as is as we'll be switching up to go 1.22 soon anyway

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants