github: update CI to run most tests with Go 1.21 with build/compat test with 1.20 #12822
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simondeziel
force-pushed
the
ci-1.21
branch
4 times, most recently
from
1e5f73c
to
75b0b94
Compare
Yep that makes sense. Can you include in this PR please. |
|
@simondeziel is go 1.22 available in GH yet? As its just been released and we should use that as we plan to use it for the next LTS release https://go.dev/doc/go1.22 |
|
@tomponline yes Go 1.22 is available but it didn't fare well, Go segfaults during Update: the same crash happened on a retry. |
simondeziel
force-pushed
the
ci-1.21
branch
2 times, most recently
from
7c5d96c
to
d83c3df
Compare
|
@tomponline I propose we go with 1.21 for now and revisit 1.22 in a few days or maybe when they publish a point release. |
|
Testing locally with go |
tomponline
reviewed
Feb 7, 2024
tomponline
approved these changes
Feb 7, 2024
tomponline
requested changes
Feb 7, 2024
Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
This was risky because if another snap (like mdl) moved to a core20 base, we'd be removing core20 just to download it again. Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
This is to reclaim some space. Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
…et@v0.4.1" This reverts commit 218af92. Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
|
CI is all green now. |
Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
tomponline
approved these changes
Feb 8, 2024
|
@simondeziel please can you backport appropriate changes to 5.0-edge too so we can keep these GH workflows in sync as best as possible (taking into account the min go versions are different). Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@tomponline I had to re-introduce the pining of
github.com/mdlayher/socket@v0.4.1in order to havego mod tidy -go=1.20work when using Go 1.20 (see theCheck compatibility with min Go version (${{ matrix.go }})test step).In #12794 (comment) you confirmed you ran into this issue with Go 1.21 (like I do) and that's further confirmed by upstream claiming this module to require 1.21+: https://github.com/mdlayher/socket/blob/main/CHANGELOG.md#v050
That said, since we have now bumped the requirement for Go to be 1.21+, maybe we should actually drop compat with 1.20? Happy to do so here or in a subsequent PR.