Storage: Rework volume volatile.uuid patch
#13162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomponline
reviewed
Mar 15, 2024
tomponline
reviewed
Mar 15, 2024
|
I just saw I could also make the |
This patch supersedes patchStorageSetVolumeUUID as it isn't affected by the leader election. Signed-off-by: Julian Pelizäus <julian.pelizaeus@canonical.com>
roosterfish
force-pushed
the
rework_uuid_patch
branch
from
0051432
to
2dc5a41
Compare
roosterfish
force-pushed
the
rework_uuid_patch
branch
from
2dc5a41
to
c309ce8
Compare
tomponline
reviewed
Mar 15, 2024
tomponline
reviewed
Mar 15, 2024
Signed-off-by: Julian Pelizäus <julian.pelizaeus@canonical.com>
Signed-off-by: Julian Pelizäus <julian.pelizaeus@canonical.com>
roosterfish
force-pushed
the
rework_uuid_patch
branch
from
c309ce8
to
3e4eb17
Compare
Absolutely, I haven't really thought about using one. Would you see any impact by not using a transaction? |
If one fails it'll fallback. But im not sure we want this in this case. Happy to leave as is. |
tomponline
approved these changes
Mar 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reworks the patch added in #12840 so that it always applies the new
volatile.uuidin any case without needing to rely on the LXD clusters leader election.I tried to reuse the same select query for all three cases, not sure if it's worth adding this complexity but it looks cleaner in my opinion.
Additionally I have fixed a bug in which new image volumes don't get a new
volatile.uuid. This was missed whilst introducing the newGetNewVolume()function which now also adds avolatile.uuidto the volume's config.