Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Alt+` is confusing Firefox #3379

Closed
AlanGriffiths opened this issue May 7, 2024 · 3 comments
Closed

Alt+` is confusing Firefox #3379

AlanGriffiths opened this issue May 7, 2024 · 3 comments

Comments

@AlanGriffiths
Copy link
Contributor

When I updated my Miriway snap to Mir trunk I discovered weirdness...

  1. Open a couple of Firefox windows.
  2. Alt-` between them
  3. Move over a scrollable area and drag two fingers up/down

Expect: area scolls
Actual: Firefox revisits history
@AlanGriffiths
Copy link
Contributor Author

Probably same as #3307, but happens consistently now

@mattkae
Copy link
Contributor

mattkae commented May 7, 2024 •
edited
Loading

Aha! you know what... I've seen this before in miracle-wm, but I couldn't quite put my finger on it: miracle-wm-org/miracle-wm#42 (This was with firefox)

mattkae added a commit that referenced this issue May 7, 2024
@mattkae
(#3379 #3307) Fix accidentally consuming input events on alt key up
417a3b8
github-merge-queue bot pushed a commit that referenced this issue May 8, 2024
@RAOF
(#3379 #3307) Fix accidentally consuming input events on alt key up (#…
d26f7a6 
…3382)

## What's new?
- We were erroneously eating the event on complete, which made the final
"up" on an alt some times not complete 🤦
AlanGriffiths pushed a commit that referenced this issue May 8, 2024
@RAOF @AlanGriffiths
(#3379 #3307) Fix accidentally consuming input events on alt key up (#…
277aacc 
…3382)

## What's new?
- We were erroneously eating the event on complete, which made the final
"up" on an alt some times not complete 🤦
@AlanGriffiths
Copy link
Contributor Author

Fixed by #3382

@AlanGriffiths AlanGriffiths mentioned this issue Sep 9, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@AlanGriffiths @mattkae