Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(#3379 #3307) Fix accidentally consuming input events on alt key up #3382

Merged
merged 3 commits into from
May 8, 2024
Merged

(#3379 #3307) Fix accidentally consuming input events on alt key up #3382

merged 3 commits into from
May 8, 2024

Conversation

mattkae
Copy link
Contributor

@mattkae mattkae commented May 7, 2024

What's new?

  • We were erroneously eating the event on complete, which made the final "up" on an alt some times not complete 🤦

@mattkae mattkae requested a review from AlanGriffiths May 7, 2024 19:02
@mattkae mattkae requested a review from a team as a code owner May 7, 2024 19:02
@codecov Codecov
Copy link

codecov bot commented May 7, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 77.52%. Comparing base (426d917) to head (509b132).

Files Patch % Lines
src/miral/minimal_window_manager.cpp 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #3382   +/-   ##
=======================================
  Coverage   77.51%   77.52%           
=======================================
  Files        1075     1075           
  Lines       68298    68283   -15     
=======================================
- Hits        52943    52936    -7     
+ Misses      15355    15347    -8

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mattkae mattkae requested a review from AlanGriffiths May 7, 2024 20:56
RAOF
RAOF approved these changes May 8, 2024
View reviewed changes
Copy link
Contributor

@RAOF RAOF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aha!

@RAOF RAOF added this pull request to the merge queue May 8, 2024
Merged via the queue into main with commit d26f7a6 May 8, 2024
30 of 33 checks passed
@RAOF RAOF deleted the bugfix/3379 branch May 8, 2024 00:47
AlanGriffiths pushed a commit that referenced this pull request May 8, 2024
@RAOF @AlanGriffiths
(#3379 #3307) Fix accidentally consuming input events on alt key up (#…
277aacc 
…3382)

## What's new?
- We were erroneously eating the event on complete, which made the final
"up" on an alt some times not complete 🤦
This was referenced May 8, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RAOF RAOF RAOF approved these changes

@AlanGriffiths AlanGriffiths Awaiting requested review from AlanGriffiths

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mattkae @RAOF @AlanGriffiths