Implement DEPRECATED mysql-shared interface
#49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlcsaposs-canonical
force-pushed
the
legacy-interface
branch
from
f8bb24a
to
6a8e044
Compare
carlcsaposs-canonical
requested review from
paulomach,
taurus-forever and
shayancanonical
Traceback (most recent call last):
File "/var/lib/juju/agents/unit-mysqlrouter-0/charm/./src/machine_charm.py", line 59, in <module>
ops.main.main(MachineSubordinateRouterCharm)
File "/var/lib/juju/agents/unit-mysqlrouter-0/charm/venv/ops/main.py", line 429, in main
charm = charm_class(framework)
File "/var/lib/juju/agents/unit-mysqlrouter-0/charm/./src/machine_charm.py", line 28, in __init__
self._database_provides = relations.database_providers_wrapper.RelationEndpoint(self)
File "/var/lib/juju/agents/unit-mysqlrouter-0/charm/src/relations/database_providers_wrapper.py", line 32, in __init__
self._database_provides = relations.database_provides.RelationEndpoint(charm_)
File "/var/lib/juju/agents/unit-mysqlrouter-0/charm/src/relations/database_provides.py", line 149, in __init__
self._interface = data_interfaces.DatabaseProvides(charm_, relation_name=self._NAME)
File "/var/lib/juju/agents/unit-mysqlrouter-0/charm/lib/charms/data_platform_libs/v0/data_interfaces.py", line 756, in __init__
super().__init__(charm, relation_name)
File "/var/lib/juju/agents/unit-mysqlrouter-0/charm/lib/charms/data_platform_libs/v0/data_interfaces.py", line 373, in __init__
super().__init__(charm, relation_name)
File "/var/lib/juju/agents/unit-mysqlrouter-0/charm/venv/ops/framework.py", line 412, in __init__
self.framework._track(self)
File "/var/lib/juju/agents/unit-mysqlrouter-0/charm/venv/ops/framework.py", line 661, in _track
raise RuntimeError(
RuntimeError: two objects claiming to be MachineSubordinateRouterCharm/DatabaseProvides[database] have been created
from https://github.com/canonical/mysql-router-operator/actions/runs/5404925316/jobs/9819825535
peer relation not available in install event
carlcsaposs-canonical
force-pushed
the
legacy-interface
branch
from
578b9b4
to
069bcbe
Compare
taurus-forever
approved these changes
Jun 30, 2023
| if isinstance(exception, exception_type): | ||
| return exception.status | ||
| if requested_users: | ||
| return ops.ActiveStatus("'mysql-shared' interface deprecated") |
paulomach
approved these changes
Jul 3, 2023
| self._local_unit_databag["allowed_units"] = self._remote_unit_name | ||
| self._local_unit_databag["db_host"] = "127.0.0.1" | ||
| self._local_unit_databag["db_port"] = "3306" | ||
| self._local_unit_databag["wait_timeout"] = "3600" |
There was a problem hiding this comment.
So, this comes from mysql configuration
The legacy charm supports a config and default it to 3600, but since we are not supporting the config, we should reflect the sysvar default, i.e. 28800.
A task was added to mirror this on the vm charm.
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mysql-router from 8.0/stable (written by OpenStack Charmers) supports mysql-shared interface
Add support for mysql-shared interface
DPE-2035