Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check if relation is breaking during relation-broken event #50

Merged
merged 9 commits into from
Jul 14, 2023

Conversation

carlcsaposs-canonical
Copy link
Contributor

@carlcsaposs-canonical
Copy link
Contributor Author

Depends on #49

Copy link
Contributor

@shayancanonical shayancanonical left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great workaround! - will adopt this in the legacy-mysql relation in the mysql operator as you recommended

Base automatically changed from legacy-interface to main July 3, 2023 16:54
@carlcsaposs-canonical
Copy link
Contributor Author

carlcsaposs-canonical commented Jul 3, 2023

Blocked by https://bugs.launchpad.net/juju/+bug/2025676

Workaround found: https://bugs.launchpad.net/juju/+bug/2025676/comments/1

@taurus-forever
Copy link
Contributor

Blocked by https://bugs.launchpad.net/juju/+bug/2025676

re: https://bugs.launchpad.net/juju/+bug/2025676/comments/3 it looks like no fix planned. @carlcsaposs-canonical are you planning to rework this?

@carlcsaposs-canonical
Copy link
Contributor Author

Blocked by https://bugs.launchpad.net/juju/+bug/2025676

re: https://bugs.launchpad.net/juju/+bug/2025676/comments/3 it looks like no fix planned. @carlcsaposs-canonical are you planning to rework this?

@taurus-forever Oops, that's outdated

Marcelo found a workaround that I updated the PR with

Copy link
Contributor

@paulomach paulomach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we must keep an eye on a final fix (the bug won't be fixed).
Meanwhile that's a great solution

Copy link
Contributor

@taurus-forever taurus-forever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. BTW, great description!

@carlcsaposs-canonical carlcsaposs-canonical merged commit f2c3aec into main Jul 14, 2023
7 of 8 checks passed
@carlcsaposs-canonical carlcsaposs-canonical deleted the relation-broken-fix branch July 14, 2023 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants