Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ckf-1.7 branch doesn't check if public_url is configured #107

Closed
orfeas-k opened this issue Sep 6, 2023 · 2 comments
Closed

ckf-1.7 branch doesn't check if public_url is configured #107

orfeas-k opened this issue Sep 6, 2023 · 2 comments
Labels
bug Something isn't working

Comments

@orfeas-k
Copy link
Contributor

orfeas-k commented Sep 6, 2023

As explained also here, 1.7/edge channel uses revision 250. Taking a look at rev250 code, we see that the charm code has the _check_public_url method, but it seems like it is not called anywhere. Thus, the charm will never catch that the configuration is not there.

Solution

Implement following in ckf-1.7/track

diff --git a/src/charm.py b/src/charm.py
index 4378d31..375037f 100755
--- a/src/charm.py
+++ b/src/charm.py
@@ -42,6 +42,7 @@ class Operator(CharmBase):
 
             image_details = self._check_image_details()
 
+            self._check_public_url()
         except CheckFailed as error:
             self.model.unit.status = error.status
             return
@orfeas-k orfeas-k added the bug Something isn't working label Sep 6, 2023
@orfeas-k
Copy link
Contributor Author

orfeas-k commented Sep 8, 2023

Related to #18

orfeas-k added a commit that referenced this issue Sep 11, 2023
Block charm when `public_url` is not configured
Partial backport of #78
Closes #107
Closes #18
@orfeas-k
Copy link
Contributor Author

Closed by #108

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Development

No branches or pull requests

1 participant