Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If public-url is undefined, charm "works" (green/pod alive) but doesn't do anything useful #18

Closed
ca-scribner opened this issue Feb 11, 2022 · 2 comments
Assignees
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@ca-scribner
Copy link
Contributor

If deployed and related to the appropriate charms but not set with a public-url, OIDC-gatekeeper will show:

  • Active in juju
  • pod running
  • pod logs show repeated messages of time="2022-02-11T18:18:01Z" level=error msg="OIDC provider setup failed, retrying in 10 seconds: Get /dex/.well-known/openid-configuration: unsupported protocol scheme \"\""
    This will also result in a blank screen if trying to browse to the ingress IP because the dex+oidc handling of the login is broken. No useful messages are provided to the user to identify what is wrong.

I think at minimum we need better messaging about this to nudge users in the right direction. But I also think (? haven't thought it through deeply) the oidc-gatekeeper charm shouldn't be live at all if it has no public-url. With public-url="" it just tries to do the auth flow with a non-sensical IP address. A deeper look into this might show we're doing it right but it seems worth a look. Either way, for our purposes I don't think juju status should show green if this is the case as no users can log in

@ca-scribner ca-scribner added the bug Something isn't working label Feb 11, 2022
@ca-scribner
Copy link
Contributor Author

As pointed out by @grobbie, rather than setting public-url directly should we get the info we need from a relation with dex-auth?

@DnPlas DnPlas added the good first issue Good for newcomers label May 2, 2023
orfeas-k added a commit that referenced this issue Sep 11, 2023
Block charm when `public_url` is not configured
Partial backport of #78
Closes #107
Closes #18
@orfeas-k
Copy link
Contributor

Closed by #108

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
Development

No branches or pull requests

4 participants