feat, docs: merge KF-5546-oidc-provider-dev-branch into main #168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a section describing how this charm can only be used as an OIDC client when Dex and Charmed Kubeflow are deployed in the model; otherwise it will fail, as there are multiple parts of this charm's code that are tightly coupled to those. Fixes #159
#163) This commit integrates the `oidc-gatekeeper` charm with `dex-auth` via the `dex-oidc-config` interface. `dex-auth` (see canonical/dex-auth-operator#203) recently introduced the aforementioned interface, which will help us remove the `public-url` configuration option as the main way of configuring oidc-gatekeeper's OIDC_AUTH_PROVIDER env variable. The new relation provides all the information that is required for setting that env variable, so this charm and its users should not change it. The changes in this PR include: * Removing the `public-url` configuration option entirely (a backwards compatible solution is not required in this case because dex-auth already has it) -> this tackles #157 * Removing all traces of the public-url from the charm code and test code * Integrating with the new interface and use the relation data to render were needed -> this tackles #156 * Adding the `dex_oidc_config` library to this charm so the interface is handled by it * Adding some extra requirements for the library to work Fixes #156 Fixes #157
orfeas-k
approved these changes
Jul 26, 2024
This was referenced Jul 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the following changes in
main:public-url#163)