Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Adds supports to generate a CA certificate #40

Merged
merged 2 commits into from
Nov 1, 2023
Merged

feat: Adds supports to generate a CA certificate #40

merged 2 commits into from
Nov 1, 2023

Conversation

gruyaume
Copy link
Contributor

Description

This PR adds supports to generate a CA certificate. It is dependent on the following PR's being merged first:

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that validate the behaviour of the software
  • I validated that new and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have bumped the version of the library

@gruyaume gruyaume mentioned this pull request Oct 27, 2023
Closed
6 tasks
@gruyaume gruyaume marked this pull request as ready for review October 31, 2023 15:30
@gruyaume gruyaume requested a review from a team as a code owner October 31, 2023 15:30
gatici
gatici approved these changes Nov 1, 2023
View reviewed changes
Copy link
Contributor

@gatici gatici left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gruyaume gruyaume merged commit 2db375d into main Nov 1, 2023
9 checks passed
@gruyaume gruyaume deleted the dev-ca branch November 1, 2023 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saltiyazan saltiyazan saltiyazan approved these changes

@gatici gatici gatici approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gruyaume @gatici @saltiyazan