Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Implements option to request a CA certificate #83

Merged
merged 2 commits into from
Oct 31, 2023
Merged

feat: Implements option to request a CA certificate #83

merged 2 commits into from
Oct 31, 2023

Conversation

gruyaume
Copy link
Collaborator

Description

Implements option to request for a CA certificate. This PR should be kept in draft until the one in charm relation interface is merged:

Checklist

  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • I have made corresponding changes to the documentation.
  • I have added tests that validate the behaviour of the software.
  • I validated that new and existing unit tests pass locally with my changes.
  • Any dependent changes have been merged and published in downstream modules.
  • I have bumped the version of any required library.

@gruyaume gruyaume requested a review from a team as a code owner October 26, 2023 20:03
@gruyaume gruyaume marked this pull request as draft October 26, 2023 20:17
@gruyaume gruyaume changed the title feat: Implements option to request for a CA certificate feat: Implements option to request a CA certificate Oct 26, 2023
@gruyaume gruyaume marked this pull request as ready for review October 27, 2023 15:54
This was referenced Oct 27, 2023
Closed
Merged
ghislainbourgeois
ghislainbourgeois requested changes Oct 31, 2023
View reviewed changes
Copy link
Contributor

@ghislainbourgeois ghislainbourgeois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall, added some small comments.

lib/charms/tls_certificates_interface/v2/tls_certificates.py Outdated Show resolved Hide resolved
lib/charms/tls_certificates_interface/v2/tls_certificates.py Outdated Show resolved Hide resolved
lib/charms/tls_certificates_interface/v2/tls_certificates.py Outdated Show resolved Hide resolved
lib/charms/tls_certificates_interface/v2/tls_certificates.py Outdated Show resolved Hide resolved
lib/charms/tls_certificates_interface/v2/tls_certificates.py Show resolved Hide resolved
@gruyaume
feat: Implements option to request for a CA certificate
a9dd1e6 
tests: Improves unit tests

Update lib/charms/tls_certificates_interface/v2/tls_certificates.py

Co-authored-by: Ghislain Bourgeois <ghislain.bourgeois@canonical.com>

Update lib/charms/tls_certificates_interface/v2/tls_certificates.py

Co-authored-by: Ghislain Bourgeois <ghislain.bourgeois@canonical.com>

Update lib/charms/tls_certificates_interface/v2/tls_certificates.py

Co-authored-by: Ghislain Bourgeois <ghislain.bourgeois@canonical.com>

Update lib/charms/tls_certificates_interface/v2/tls_certificates.py

Co-authored-by: Ghislain Bourgeois <ghislain.bourgeois@canonical.com>

updates docstring
DanielArndt
DanielArndt approved these changes Oct 31, 2023
View reviewed changes
Copy link
Member

@DanielArndt DanielArndt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gruyaume gruyaume merged commit ec43c12 into main Oct 31, 2023
8 checks passed
@gruyaume gruyaume deleted the dev-ca branch October 31, 2023 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ghislainbourgeois ghislainbourgeois ghislainbourgeois approved these changes

@DanielArndt DanielArndt DanielArndt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gruyaume @DanielArndt @ghislainbourgeois