Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor command_group usage #4911

Closed
mr-cal opened this issue Jul 11, 2024 · 2 comments · Fixed by #5007
Closed

Refactor command_group usage #4911

mr-cal opened this issue Jul 11, 2024 · 2 comments · Fixed by #5007
Labels
enhancement New features or optimizations triaged

Comments

@mr-cal
Copy link
Collaborator

mr-cal commented Jul 11, 2024 •
edited
Loading

What needs to get done

Snapcraft should

  1. stop overriding craft-application's command_group property
  2. Replace snapcraft.cli.CommandGroup with craft_cli.CommandGroup

Why it needs to get done

Code cleanup
@mr-cal mr-cal added the triaged label Jul 11, 2024
@syncronize-issues-to-jira Syncronize issues to Jira
Copy link

Thank you for reporting us your feedback!

The internal ticket has been created: https://warthogs.atlassian.net/browse/CRAFT-3106.

This message was autogenerated

mr-cal added a commit that referenced this issue Jul 22, 2024
@mr-cal
chore: add issue number to overriding the command_groups property
672bbd6 
The task to refactor commands in Snapcraft is tracked in #4911.

Signed-off-by: Callahan Kovacs <callahan.kovacs@canonical.com>
@mr-cal mr-cal mentioned this issue Jul 22, 2024
Merged
4 tasks
mr-cal added a commit that referenced this issue Jul 23, 2024
@mr-cal
chore: add issue number to overriding the command_groups property (#4934
6a38887 
)

The task to refactor commands in Snapcraft is tracked in #4911.

Signed-off-by: Callahan Kovacs <callahan.kovacs@canonical.com>
@mr-cal mr-cal added the enhancement New features or optimizations label Aug 15, 2024
@mr-cal
Copy link
Collaborator Author

mr-cal commented Aug 15, 2024

I started this as a side effort but it is complex enough that it needs to be scheduled in a pulse.

WIP: bc969db

This was referenced Aug 26, 2024
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New features or optimizations triaged
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor(application): commands, pre-run validation canonical/snapcraft
1 participant
@mr-cal