Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: migrate commands to craft-application #4830

Merged
merged 15 commits into from
Jun 4, 2024

Conversation

mr-cal
Copy link
Collaborator

@mr-cal mr-cal commented May 31, 2024

  • Have you followed the guidelines for contributing?
  • Have you signed the CLA?
  • Have you successfully run tox run -m lint?
  • Have you successfully run tox run -e test-py310? (supported versions: py39, py310, py311, py312)

Migrate the remaining commands to core24/craft-application. This is broken into many discrete commits.

Behavioral changes:

  • snapcraft list-plugins no longer errors when in a core24 project directory
  • snapcraft init creates a core24 snapcraft.yaml file, instead of core22
  • snapcraft list-plugins shows core24 plugins when not in a snapcraft project directory, instead of core22
  • command reference docs are based on core24 lifecycle commands, instead of core22

Fixes #4742
(CRAFT-2822)

Signed-off-by: Callahan Kovacs <callahan.kovacs@canonical.com>
Signed-off-by: Callahan Kovacs <callahan.kovacs@canonical.com>
Signed-off-by: Callahan Kovacs <callahan.kovacs@canonical.com>
Signed-off-by: Callahan Kovacs <callahan.kovacs@canonical.com>
Signed-off-by: Callahan Kovacs <callahan.kovacs@canonical.com>
@mr-cal mr-cal added the rebase label May 31, 2024
@mr-cal mr-cal changed the title refractor: migrate commands to craft-application refactor: migrate commands to craft-application May 31, 2024
@mr-cal mr-cal force-pushed the work/CRAFT-2822-migrate-commands branch from 97992e3 to 6f455d0 Compare May 31, 2024 16:17
Signed-off-by: Callahan Kovacs <callahan.kovacs@canonical.com>
@mr-cal mr-cal force-pushed the work/CRAFT-2822-migrate-commands branch from 6f455d0 to 4175716 Compare May 31, 2024 18:02
Signed-off-by: Callahan Kovacs <callahan.kovacs@canonical.com>
Signed-off-by: Callahan Kovacs <callahan.kovacs@canonical.com>
Signed-off-by: Callahan Kovacs <callahan.kovacs@canonical.com>
Signed-off-by: Callahan Kovacs <callahan.kovacs@canonical.com>
Signed-off-by: Callahan Kovacs <callahan.kovacs@canonical.com>
@mr-cal mr-cal force-pushed the work/CRAFT-2822-migrate-commands branch from 4175716 to 90d6b68 Compare May 31, 2024 19:08
@mr-cal mr-cal requested review from lengau and tigarmo May 31, 2024 20:29
snapcraft/cli.py Show resolved Hide resolved
@mr-cal mr-cal requested a review from cmatsuoka June 3, 2024 15:34
@mr-cal mr-cal requested a review from cmatsuoka June 3, 2024 19:21
Copy link
Contributor

@cmatsuoka cmatsuoka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mr-cal mr-cal added squash and removed rebase labels Jun 4, 2024
snapcraft/const.py Outdated Show resolved Hide resolved
Signed-off-by: Callahan Kovacs <callahan.kovacs@canonical.com>
Signed-off-by: Callahan Kovacs <callahan.kovacs@canonical.com>
@mr-cal mr-cal merged commit 0bee372 into main Jun 4, 2024
9 of 10 checks passed
@mr-cal mr-cal mentioned this pull request Jun 7, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate commands to craft-application command
4 participants