Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ROS 2 Jazzy content-sharing support #4828

Merged
merged 5 commits into from
Jun 6, 2024

Conversation

artivis
Copy link
Contributor

@artivis artivis commented May 30, 2024

Follows #4791

  • Have you followed the guidelines for contributing?
  • Have you signed the CLA?
  • Have you successfully run tox run -m lint?
  • Have you successfully run tox run -e test-py310? (supported versions: py39, py310, py311, py312)

Signed-off-by: artivis <jeremie.deray@canonical.com>
@artivis artivis force-pushed the feature/ros2-jazzy-content branch from b14a46a to 49a4ea8 Compare May 31, 2024 08:08
Signed-off-by: artivis <jeremie.deray@canonical.com>
@artivis artivis marked this pull request as ready for review May 31, 2024 10:17
@artivis
Copy link
Contributor Author

artivis commented May 31, 2024

The 2 failing spread tests aren't related to this PR.

Copy link
Collaborator

@mr-cal mr-cal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

I'm glad to see that the implementation was similar to content-sharing in core22.

snapcraft/extensions/ros2_jazzy_desktop.py Outdated Show resolved Hide resolved
@mr-cal mr-cal requested a review from cmatsuoka June 4, 2024 21:02
Signed-off-by: artivis <jeremie.deray@canonical.com>
Copy link
Contributor

@cmatsuoka cmatsuoka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@mr-cal mr-cal merged commit b0880a0 into canonical:main Jun 6, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants