-
Notifications
You must be signed in to change notification settings - Fork 447
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
extension: add ROS 2 Jazzy (core24) #4791
Conversation
fcb4b2d
to
32c3809
Compare
Signed-off-by: artivis <jeremie.deray@canonical.com>
56000df
to
5ab1cf1
Compare
The failing spread test is flutter and thus unrelated to this pr. |
@Guillaumebeuzeboc review please? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, I have some minor feedback on the tests.
Signed-off-by: artivis <jeremie.deray@canonical.com>
Signed-off-by: artivis <jeremie.deray@canonical.com>
Signed-off-by: artivis <jeremie.deray@canonical.com>
Signed-off-by: artivis <jeremie.deray@canonical.com>
Signed-off-by: artivis <jeremie.deray@canonical.com>
Not sure why the codespell CI job would fail on legacy stuff here. Should this be rebased maybe? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Yeah, codespell got updated and started flagging more words. It should be fixed with an update. |
tox run -m lint
?tox run -e test-py310
? (supported versions:py39
,py310
,py311
,py312
)