Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extension: add ROS 2 Jazzy (core24) #4791

Merged
merged 8 commits into from
May 30, 2024
Merged

Conversation

artivis
Copy link
Contributor

@artivis artivis commented May 7, 2024

  • Have you followed the guidelines for contributing?
  • Have you signed the CLA?
  • Have you successfully run tox run -m lint?
  • Have you successfully run tox run -e test-py310? (supported versions: py39, py310, py311, py312)

Signed-off-by: artivis <jeremie.deray@canonical.com>
@artivis
Copy link
Contributor Author

artivis commented May 15, 2024

The failing spread test is flutter and thus unrelated to this pr.

@artivis
Copy link
Contributor Author

artivis commented May 15, 2024

@Guillaumebeuzeboc review please?

Copy link
Collaborator

@mr-cal mr-cal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I have some minor feedback on the tests.

snapcraft/extensions/ros2_jazzy.py Outdated Show resolved Hide resolved
snapcraft/parts/plugins/colcon_plugin.py Show resolved Hide resolved
tests/unit/parts/plugins/test_colcon.py Show resolved Hide resolved
tests/unit/parts/plugins/test_colcon.py Show resolved Hide resolved
tests/unit/parts/plugins/test_colcon.py Show resolved Hide resolved
tests/spread/extensions/snaps/ros2-jazzy-hello/task.yaml Outdated Show resolved Hide resolved
Signed-off-by: artivis <jeremie.deray@canonical.com>
Signed-off-by: artivis <jeremie.deray@canonical.com>
Signed-off-by: artivis <jeremie.deray@canonical.com>
Signed-off-by: artivis <jeremie.deray@canonical.com>
Signed-off-by: artivis <jeremie.deray@canonical.com>
@artivis
Copy link
Contributor Author

artivis commented May 28, 2024

Not sure why the codespell CI job would fail on legacy stuff here. Should this be rebased maybe?

Copy link
Collaborator

@mr-cal mr-cal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mr-cal
Copy link
Collaborator

mr-cal commented May 30, 2024

Not sure why the codespell CI job would fail on legacy stuff here. Should this be rebased maybe?

Yeah, codespell got updated and started flagging more words. It should be fixed with an update.

@mr-cal mr-cal merged commit 2e1f97b into canonical:main May 30, 2024
10 checks passed
@artivis artivis deleted the feature/ros2-jazzy branch May 31, 2024 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants