-
Notifications
You must be signed in to change notification settings - Fork 447
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: re-register dotnet for core22 #4841
Conversation
Signed-off-by: Callahan Kovacs <callahan.kovacs@canonical.com>
Signed-off-by: Callahan Kovacs <callahan.kovacs@canonical.com>
Signed-off-by: Callahan Kovacs <callahan.kovacs@canonical.com>
bb95e11
to
9b00325
Compare
Force-pushed because I dropped all changes related to running the ClassicFallback or craft-application based codepath. It's too disruptive of a change for a hotfix. |
Signed-off-by: Callahan Kovacs <callahan.kovacs@canonical.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can generalize the calls a bit more instead of being core24-specific in a future refactoring, but this solves the reported issue.
Agreed. In a point release, we should flip the paradigm such that the craft-application codepath is used by default and Snapcraft only raises |
tox run -m lint
?tox run -e test-py310
? (supported versions:py39
,py310
,py311
,py312
)Application
to allow snapcraft to register/unregister plugins per-base_known_core24
to_known_craft_app_base
in preparation for core26Fixes #4825
(CRAFT-2979)