feat(lint): migrate lint command #4732
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The spread linter test failed due to |
syu-w
force-pushed
the
CRAFT-2472-lint-command
branch
from
1627106
to
b0d718a
Compare
mr-cal
reviewed
Apr 15, 2024
There was a problem hiding this comment.
Code looks great but I'm not sure what we should do with error: snap "core24" is not available on stable
It's probably not worth our time to add a workaround since core24 will be on stable later this month.
What do you think about an xfail style check in the core24 linter spread test? The spread test would pass if error: snap "core24" is not available on stable is in the logs.
lengau
reviewed
Apr 16, 2024
syu-w
force-pushed
the
CRAFT-2472-lint-command
branch
from
b0d718a
to
c7f3510
Compare
syu-w
force-pushed
the
CRAFT-2472-lint-command
branch
from
1e70929
to
a11cd29
Compare
syu-w
force-pushed
the
CRAFT-2472-lint-command
branch
from
a11cd29
to
d515d93
Compare
|
2 workarounds, install edge |
syu-w
force-pushed
the
CRAFT-2472-lint-command
branch
from
d515d93
to
04f22bc
Compare
mr-cal
reviewed
Apr 17, 2024
mr-cal
approved these changes
Apr 17, 2024
syu-w
force-pushed
the
CRAFT-2472-lint-command
branch
from
04f22bc
to
18f1fdd
Compare
lengau
approved these changes
Apr 17, 2024
|
I'll re-address the core24 linter spread test after core24 is stable. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same logic from core22.
2 workarounds, install edge
core24if stable failed and check only part of the linter warning due to glibcundefined symbolin bash.