Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: write provenance to component metadata #4849

Merged
merged 5 commits into from
Jun 13, 2024

Conversation

mr-cal
Copy link
Collaborator

@mr-cal mr-cal commented Jun 10, 2024

  • Have you followed the guidelines for contributing?
  • Have you signed the CLA?
  • Have you successfully run tox run -m lint?
  • Have you successfully run tox run -e test-py310? (supported versions: py39, py310, py311, py312)

Write provenance to a component's meta/component.yaml file.

Also, use the SnapcraftMetadata model such that None and default fields are not written.

source: canonical/snapd#13964 (comment)

Fixes #4827
(CRAFT-2980)

Signed-off-by: Callahan Kovacs <callahan.kovacs@canonical.com>
Signed-off-by: Callahan Kovacs <callahan.kovacs@canonical.com>
The edge channel of snapd supports `provenance` in component metadata.

Signed-off-by: Callahan Kovacs <callahan.kovacs@canonical.com>
@mr-cal mr-cal force-pushed the work/CRAFT-2980-component-provenance branch from b0a9014 to 678f9ea Compare June 11, 2024 16:54
@mr-cal
Copy link
Collaborator Author

mr-cal commented Jun 11, 2024

Waiting on canonical/snapd#14067 to land and be available on edge

@mr-cal mr-cal requested review from cmatsuoka and lengau June 12, 2024 14:53
Copy link
Contributor

@lengau lengau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM presuming the snapd update makes the two failing spread tests pass.

@mr-cal mr-cal requested a review from tigarmo June 13, 2024 16:34
@mr-cal mr-cal merged commit be64030 into main Jun 13, 2024
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Write provenance to component metadata
3 participants