many: add Provenance field to ComponentInfo #14067
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Needs Documentation -auto-
andrewphelpsj
commented
Jun 11, 2024
| @@ -346,7 +346,7 @@ func (s *packSuite) TestDebArchitecture(c *C) { | |||
| c.Check(pack.DebArchitecture(&snap.Info{Architectures: nil}), Equals, "all") | |||
| } | |||
|
|
|||
| func (s *packSuite) TestPackSimple(c *C) { | |||
There was a problem hiding this comment.
I think these names got swapped accidentally at some point, TestPackSimple was testing packing a component, and TestPackComponentSimple was testing packing a snap.
andrewphelpsj
force-pushed
the
add-provenance-to-component
branch
from
8672d10
to
3e86fb0
Compare
pedronis
reviewed
Jun 11, 2024
| // NewComponentInfo creates a new ComponentInfo. | ||
| func NewComponentInfo(cref naming.ComponentRef, ctype ComponentType, version, summary, description string, csi *ComponentSideInfo) *ComponentInfo { | ||
| func NewComponentInfo(cref naming.ComponentRef, ctype ComponentType, version, summary, description, provenance string, csi *ComponentSideInfo) *ComponentInfo { |
There was a problem hiding this comment.
with so many arguments it's getting a bit unclear whether this is more readable than &struct{}
4 tasks
pedronis
approved these changes
Jun 11, 2024
| @@ -55,6 +55,7 @@ type: test | |||
| version: 1.0 | |||
| summary: short description | |||
| description: long description | |||
| provenance: prov | |||
There was a problem hiding this comment.
do we still have tests here where this is empty but validates?
There was a problem hiding this comment.
Yes, TestReadComponentInfoMinimal covers that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a
Provenancetosnap.ComponentInfo. This allowssnap packto work with components that define a provenance in theircomponent.yamlfile.