-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adapt tree list component for content CMS #5270
Conversation
looks good, just a couple of notes:
active should appear just once, on the leaf node corresponding to the page view displayed in a hypothetical adjacent panel controlled by this componoent. I suggest bold as the simplest thing, that doesn't get in theway of indents |
@lyubomir-popov I'm not certain about this - doesn't this change this component to function more like side navigation, rather than as a list? Maybe we're starting to muddy this component's purpose. My best UX understanding here is that the active state is there to help the user trace through the open tree structure, not to indicate a specific active node. I'm happy to implement it, just want to be sure I have a clear understanding of this component's purpose. |
spec should answer https://www.w3.org/WAI/ARIA/apg/patterns/treeview/ |
ae29447
to
57dfe63
Compare
57dfe63
to
60a495a
Compare
@lyubomir-popov Updated - have a look again please! Be sure to check on small and large screens (indentation changes to align with side navigation) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
60a495a
to
1616b96
Compare
713d8d2
to
0cb6910
Compare
@pastelcyborg I've adjusted the margin slightly to eliminate this issue: |
…nd metrics concerns
…y (help with maas ui issue)
3a53cdf
to
61e3402
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks!
There may have been some hiccup with Percy, as it seems it didn't run? |
Hi @akbarkz - this is nearing merge, have a look at dark list tree and docs and let me know if you have any thoughts / concerns :) |
Done
is-active
styling and scripting to allow the component to behave more like a navigation componenta.p-list-tree__link
inside ofli.p-list-tree__item
, which improves keyboard accessibility.Fixes #5269, WD-11827, WD-13882
QA
Check if PR is ready for release
If this PR contains Vanilla SCSS code changes, it should contain the following changes to make sure it's ready for the release:
Feature 🎁
,Breaking Change 💣
,Bug 🐛
,Documentation 📝
,Maintenance 🔨
.package.json
should be updated relative to the most recent release, following semver convention:Screenshots
Before:

After:
