Manually set baseline build commit signature #5340
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Done
#5300 updated the Percy workflow to merge
main
into a PR before it is tested, but our dual-workflow approach seems to throw a wrench in Percy's baseline build detection: even though the files being tested are a merge ofmain
with a PR, Percy may select a baseline build that is older than the current baseline build, causing false positive test results.This occurred in #5338 (PR branch was cut from main before merge of #5270). However the Percy build used a baseline build from before the merge of #5270), causing the tree list snapshots to incorrectly appear as new. It appears Percy needs to be manually instructed to use the latest
main
commit for this two-workflow approach to not have hiccups with merge conflicts. This can be done with environment variables.This should mean that you only need to merge/rebase branches for Percy tests where source merge conflicts exist.
QA
Check if PR is ready for release
If this PR contains Vanilla SCSS code changes, it should contain the following changes to make sure it's ready for the release:
Feature 🎁
,Breaking Change 💣
,Bug 🐛
,Documentation 📝
,Maintenance 🔨
.package.json
should be updated relative to the most recent release, following semver convention: