Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert tests to use a matrix, add support for Houdini 20.0 #11

Closed
captainhammy opened this issue Nov 10, 2023 · 0 comments · Fixed by #12
Closed

Convert tests to use a matrix, add support for Houdini 20.0 #11

captainhammy opened this issue Nov 10, 2023 · 0 comments · Fixed by #12
Assignees
@captainhammy
Labels
testing Improvements or bug fixes related to testing

Comments

@captainhammy
Copy link
Owner

Now that Houdini 20.0 (and a version of hython-runner for it) we should add testing support against it. We might as well maintain support for 19.5 while we're at it.

To do this we'll want to split out the tox test targets to support both 19.5 and 20 (via hython flag for my current rez based local setup) as well as switch to using a matrix for the github actions portion.
@captainhammy captainhammy added the enhancement New feature or request label Nov 10, 2023
@captainhammy captainhammy self-assigned this Nov 10, 2023
captainhammy added a commit that referenced this issue Nov 10, 2023
@captainhammy
test: add support for Houdini 20.0
2e2861e 
To do this (and make future versions easier) the testing is converted to a more Houdin version-centric
approach rather than the Python version. This has some additional requirements:

Local Testing:

For local testing, the tox targets have been renamed from using the standard Python names (py39, py310, etc)
to the Houdini versions (h195, h20). Since I use Houdini via rez, in order to select a version I need to
pass along a version qualifier to ensure that the correct version is launched so this is now accomplished
via an extra env var (defaulting to empty) that the Houdini specific targets can set and will be added
to the hython command. Since the Github targets rely on Houdini already being available and set up they
will not care about this and will function as expected.

Github Actions:

For Github, the version is now chosen via a matrix on the major.minor version. As specific versions of
Python are still needed, we specify that via matching include fields. We also need to add a new 3.10
gh-actions tox entry to execute with py310.

We also bump the version of install-houdini-apprentice-license-action to 5 in order to no longer need
to specify a Houdini version for the license. This change necessitates that we ensure the setup-python
action is called before the license action as that is no longer setting up the python that it needs.

fixes: #11
@captainhammy captainhammy added testing Improvements or bug fixes related to testing and removed enhancement New feature or request labels Nov 10, 2023
@captainhammy captainhammy linked a pull request Nov 10, 2023 that will close this issue
feat: convert tests to use a matrix add support for houdini 20.0 #12
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@captainhammy captainhammy

Labels
testing Improvements or bug fixes related to testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: convert tests to use a matrix add support for houdini 20.0 captainhammy/pytest-houdini
1 participant
@captainhammy