Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: convert tests to use a matrix add support for houdini 20.0 #12

Conversation

captainhammy
Copy link
Owner

To do this (and make future versions easier) the testing is converted to a more Houdin version-centric
approach rather than the Python version. This has some additional requirements:

Local Testing:

For local testing, the tox targets have been renamed from using the standard Python names (py39, py310, etc)
to the Houdini versions (h195, h20). Since I use Houdini via rez, in order to select a version I need to
pass along a version qualifier to ensure that the correct version is launched so this is now accomplished
via an extra env var (defaulting to empty) that the Houdini specific targets can set and will be added
to the hython command. Since the Github targets rely on Houdini already being available and set up they
will not care about this and will function as expected.

Github Actions:

For Github, the version is now chosen via a matrix on the major.minor version. As specific versions of
Python are still needed, we specify that via matching include fields. We also need to add a new 3.10
gh-actions tox entry to execute with py310.

We also bump the version of install-houdini-apprentice-license-action to 5 in order to no longer need
to specify a Houdini version for the license. This change necessitates that we ensure the setup-python
action is called before the license action as that is no longer setting up the python that it needs.

fixes: #11
It looks like some parameters on existing tests nodes were removed in Houdini 20
and will cause the tests to fail due to the warnings themselves. Disabling the
load warnings will fix the tests.
@captainhammy captainhammy added the testing Improvements or bug fixes related to testing label Nov 10, 2023
@captainhammy captainhammy self-assigned this Nov 10, 2023
@captainhammy captainhammy linked an issue Nov 10, 2023 that may be closed by this pull request
@captainhammy captainhammy merged commit 622cd7f into main Nov 10, 2023
4 checks passed
@captainhammy captainhammy deleted the feature/issue-11/convert-tests-to-use-a-matrix-add-support-for-houdini-200 branch November 10, 2023 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
testing Improvements or bug fixes related to testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Convert tests to use a matrix, add support for Houdini 20.0
1 participant