Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update docker compose to v2 #114

Merged
merged 1 commit into from
Aug 12, 2024
Merged

Conversation

bthari
Copy link
Contributor

@bthari bthari commented Aug 9, 2024

Context

Docker Compose V1 has been removed from Github Runners since 29th July, which resulted in MLP integration failing (ex), as it cannot found the command docker-compose. This PR is intended to fix this issue by updating into the Docker Compose V2 command docker compose

Copy link

codecov bot commented Aug 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.62%. Comparing base (cb2772d) to head (8ff44cd).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #114      +/-   ##
==========================================
- Coverage   57.14%   56.62%   -0.52%     
==========================================
  Files          47       48       +1     
  Lines        2443     2467      +24     
==========================================
+ Hits         1396     1397       +1     
- Misses        851      874      +23     
  Partials      196      196              
Flag Coverage Δ
api-test 56.62% <ø> (-0.52%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@deadlycoconuts deadlycoconuts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for these changes! LGTM! 🚀

@bthari bthari merged commit c4379b4 into main Aug 12, 2024
8 of 10 checks passed
@bthari bthari deleted the chore-update-docker-compose branch August 12, 2024 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants