Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Table] Accessibility violation #3400

Closed
1 of 2 tasks
kalyanixraut opened this issue Mar 25, 2022 · 1 comment
Closed
1 of 2 tasks

[Table] Accessibility violation #3400

kalyanixraut opened this issue Mar 25, 2022 · 1 comment

Comments

@kalyanixraut
Copy link
Collaborator

kalyanixraut commented Mar 25, 2022

What package is this for?

  • React
  • Angular

Describe the bug

Accessibility violation is found when Table has search enabled in the toolbar. The input field needs aria-label to be set.

To Reproduce

Though I am not sure why PAL's next storybook isn't showing this accessibility violation, but Maximo Graphite which uses the Table component does throw this in its storybook's accessibility tab.
image

Adding aria-label to the input seems to fix the accessibility violation.
https://dequeuniversity.com/rules/axe/4.3/label-title-only
I think this needs to be done at carbon(carbon-components-react) end, which has the base component.

Expected behavior

Aria-label is set in the input of search and Graphite storybook should show no 'Ensures every form element has a label' accessibility violations

Environment/versions:

  • OS: [e.g. MacOS, Windows]
  • Browser: [e.g. chrome, safari]
  • carbon-addons-iot-react version: 2.149.0-next.10
@davidicus
Copy link
Collaborator

This is a bug with axe-core package. If you do the same scans in our storybook you will see that we do not have the same violations. The fix is to upgrade your version of storybook or resolve axe-core to a compatible version that has the fix included.

Please see here for more details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants