-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(tabletoolbar): add aria-label to search input #3635
Conversation
✅ Deploy Preview for carbon-addons-iot-react ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for ai-apps-pal-angular ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small change with translated string.
@@ -433,6 +433,7 @@ const TableToolbar = ({ | |||
{hasSearch ? ( | |||
<TableToolbarSearch | |||
{...search} | |||
aria-label="search" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this will be read by screen readers we should be using the translated string here.
Hey @erzhan-temir-mamyrov I have looked into this and I think this may be a false positive for Graphite's axe scans. There is a known bug that was fixed. If you look at the scans in our Storybook you will notice we do not have an a11y issue. Our version is ahead of graphite but quite a bit. If you look at the spec, Carbon is following the recommendations of providing a visibly hidden label. So, I think this one can be closed out with no need of changes on our end. |
Closes #3400
Summary
Change List (commits, features, bugs, etc)
aria-label="search"
to search inputAcceptance Test (how to verify the PR)
aria-label
is set for the input fieldRegression Test (how to make sure this PR doesn't break old functionality)
Things to look for during review
iot
orbx
class prefix is using the prefix variabledata-testid
attribute. New test ids should have test written to ensure they are not changed or removed.