feat(countdown): add components #12099
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Valentin-Sorin-Nicolae
requested review from
m4olivei,
bruno-amorim,
marcelojcs and
andy-blum
and removed request for
a team
✅ Deploy Preview for ibm-dotcom-web-components ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for ibm-dotcom-web-components-react-wrap ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
I couldn't add the snapshots, this is not working on my machine. |
m4olivei
requested changes
Nov 6, 2024
packages/web-components/src/components/countdown/__stories__/README.stories.mdx
Outdated
Show resolved
Hide resolved
packages/web-components/src/components/countdown/__stories__/countdown.stories.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: Matthew Oliveira <m4olivei@gmail.com>
Co-authored-by: Matthew Oliveira <m4olivei@gmail.com>
Co-authored-by: Matthew Oliveira <m4olivei@gmail.com>
|
I believe I've resolved all the outstanding issues here. Note that I've merged the promo-banner migration PR here. That PR should be merged first. |
…tdown-fromCAEMtoC4IBM
m4olivei
added
the
Ready to merge
kodiakhq
bot
merged commit 27bf4a3
into
carbon-design-system:main
18 of 24 checks passed
|
Hey there! This issue/pull request was referenced in recently released v2.16.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Ticket(s)
ADCMS-6655
Description
Migrates the
caem-countdowncomponent from carbon-for-aem into carbon-for-ibmdotcom asc4d-countdowncomponent.Changelog
New
c4d-countdowncomponent