Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(promo-banner): add components #12100

Merged
merged 15 commits into from
Nov 13, 2024
Merged

feat(promo-banner): add components #12100

merged 15 commits into from
Nov 13, 2024

Conversation

Valentin-Sorin-Nicolae
Copy link
Contributor

@Valentin-Sorin-Nicolae Valentin-Sorin-Nicolae commented Nov 11, 2024 •
edited by m4olivei
Loading

Related Ticket(s)

ADCMS-6656

Description

Migrates the promo-banner component from carbon-for-aem into carbon-for-ibmdotcom

Changelog

New

  • Added the c4d-promo-banner component.

@netlify Netlify
Copy link

netlify bot commented Nov 11, 2024 •
edited
Loading

✅ Deploy Preview for ibm-dotcom-web-components ready!

Name Link
🔨 Latest commit
🔍 Latest deploy log https://app.netlify.com/sites/ibm-dotcom-web-components/deploys/6734bc494ad5cb05399cd091
😎 Deploy Preview https://deploy-preview-12100--ibm-dotcom-web-components.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify Netlify
Copy link

netlify bot commented Nov 11, 2024 •
edited
Loading

✅ Deploy Preview for ibm-dotcom-web-components-react-wrap ready!

Name Link
🔨 Latest commit 0005cab
🔍 Latest deploy log https://app.netlify.com/sites/ibm-dotcom-web-components-react-wrap/deploys/67349c04f6ddd6000806a266
😎 Deploy Preview https://deploy-preview-12100--ibm-dotcom-web-components-react-wrap.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@m4olivei m4olivei marked this pull request as ready for review November 12, 2024 20:18
@m4olivei m4olivei requested a review from a team as a code owner November 12, 2024 20:18
@m4olivei m4olivei requested review from m4olivei, bruno-amorim, marcelojcs and andy-blum and removed request for a team November 12, 2024 20:18
@m4olivei m4olivei mentioned this pull request Nov 12, 2024
Merged
@m4olivei m4olivei closed this Nov 13, 2024
@m4olivei m4olivei reopened this Nov 13, 2024
m4olivei
m4olivei approved these changes Nov 13, 2024
View reviewed changes
Copy link
Contributor

@m4olivei m4olivei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good here! Thanks.

@m4olivei m4olivei added the Ready to merge Label for the pull requests that are ready to merge label Nov 13, 2024
@kodiakhq kodiakhq bot merged commit 417143c into carbon-design-system:main Nov 13, 2024
21 of 37 checks passed
@github-actions GitHub Actions
Copy link
Contributor

Hey there! This issue/pull request was referenced in recently released v2.16.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m4olivei m4olivei m4olivei approved these changes

@bruno-amorim bruno-amorim Awaiting requested review from bruno-amorim bruno-amorim is a code owner automatically assigned from carbon-design-system/carbon-for-ibm-com-members

@marcelojcs marcelojcs Awaiting requested review from marcelojcs marcelojcs is a code owner automatically assigned from carbon-design-system/carbon-for-ibm-com-members

@andy-blum andy-blum Awaiting requested review from andy-blum andy-blum is a code owner automatically assigned from carbon-design-system/carbon-for-ibm-com-members

Assignees
No one assigned
Labels
Ready to merge Label for the pull requests that are ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Valentin-Sorin-Nicolae @m4olivei