Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ComponentDemo): add padding to align dropdown labels #1706

Merged
merged 4 commits into from
Sep 14, 2020

Conversation

tw15egan
Copy link
Member

Temporary workaround for #1688 until we implement the fluid versions of all form components.

Changelog

Changed

  • 1rem margin to labels on ComponentDemo dropdowns to align the text
  • Updated copy per @janchild / @aagonzales

@tw15egan tw15egan requested a review from a team as a code owner September 11, 2020 17:54
@vercel vercel bot temporarily deployed to Preview September 11, 2020 17:54 Inactive
@vercel
Copy link

vercel bot commented Sep 11, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/carbon-design-system/carbondesignsystem/1kt3bp5er
✅ Preview: https://carbondesignsystem-git-fork-tw15egan-demo-label-tweaks.carbon-design-system.vercel.app

Copy link
Contributor

@janchild janchild left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tw15egan One tweak! :)

src/components/ComponentDemo/ComponentDemo.js Outdated Show resolved Hide resolved
Co-authored-by: Jan Child <44503588+janchild@users.noreply.github.com>
Copy link
Member

@aagonzales aagonzales left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect! Thanks for updating!

@kodiakhq kodiakhq bot merged commit d2612a3 into carbon-design-system:master Sep 14, 2020
natashadecoste pushed a commit to natashadecoste/carbon-website that referenced this pull request May 19, 2021
…gn-system#1706)

* fix(ComponentDemo): add padding to align dropdown labels

* fix(typo): use correct word

Co-authored-by: Jan Child <44503588+janchild@users.noreply.github.com>

Co-authored-by: Jan Child <44503588+janchild@users.noreply.github.com>
Co-authored-by: Alessandra Davila <aledavila@ibm.com>
Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
natashadecoste pushed a commit to natashadecoste/carbon-website that referenced this pull request May 19, 2021
…gn-system#1706)

* fix(ComponentDemo): add padding to align dropdown labels

* fix(typo): use correct word

Co-authored-by: Jan Child <44503588+janchild@users.noreply.github.com>

Co-authored-by: Jan Child <44503588+janchild@users.noreply.github.com>
Co-authored-by: Alessandra Davila <aledavila@ibm.com>
Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants