Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ComponentDemo): add padding to align dropdown labels #1706

Merged
merged 4 commits into from
Sep 14, 2020
Merged

fix(ComponentDemo): add padding to align dropdown labels #1706

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1e3fde0
fix(ComponentDemo): add padding to align dropdown labels
tw15egan Sep 11, 2020
1ff5d1d
fix(typo): use correct word
tw15egan Sep 11, 2020
a519605
Merge branch 'master' into demo-label-tweaks
Sep 14, 2020
dc09299
Merge branch 'master' into demo-label-tweaks
kodiakhq[bot] Sep 14, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 4 additions & 6 deletions src/components/ComponentDemo/ComponentDemo.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,8 +101,8 @@ const ComponentDemo = ({ children, src, scope, noInline, components }) => {
}
initialSelectedItem="White"
id="theme-variant"
label="Theme variant selection"
titleText="Theme variant selection"
label="Theme selector"
titleText="Theme selector"
items={Object.keys(themes)}
size="xl"
/>
Expand All @@ -111,10 +111,8 @@ const ComponentDemo = ({ children, src, scope, noInline, components }) => {
light
initialSelectedItem={components[0]}
id="component-variant"
titleText={
childrenArray.length === 1 ? '' : 'Component variant selection'
}
label="Component variant selection"
titleText={childrenArray.length === 1 ? '' : 'Variant selector'}
label="Variant selection"
tw15egan marked this conversation as resolved.
Show resolved Hide resolved
items={components}
size="xl"
className={cx(variantDropdown, {
Expand Down
4 changes: 4 additions & 0 deletions src/components/ComponentDemo/ComponentDemo.module.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -256,6 +256,10 @@ fieldset.form-group:last-of-type {
[class*='--list-box--light'][class*='--list-box--expanded'] {
border-bottom-width: 1px;
}

[class*='--label'] {
margin-left: 1rem;
}
}

.dropdownRow .variantDropdown {
Expand Down