Add TypeScript types to Switcher, SwitcherDivider, SwitcherItem #13584 #14989
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
DCO Assistant Lite bot All contributors have signed the DCO. |
|
I have read the DCO document and I hereby sign the DCO. |
✅ Deploy Preview for v11-carbon-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
shreeup
changed the title
|
For 'DCO Assistant / DCO (pull_request_target)' step to pass, is there any action required from my end? I have already commented saying "I have read the DCO document and I hereby sign the DCO." |
|
recheck |
tw15egan
reviewed
Nov 2, 2023
Comment on lines
577
to
611
|
|
||
| export const SwitcherItems = () => ( | ||
| <> | ||
| <Header aria-label="IBM Platform Name"> | ||
| <SkipToContent /> | ||
| <HeaderName href="#" prefix="IBM"> | ||
| Switcher | ||
| </HeaderName> | ||
| </Header> | ||
| <Switcher | ||
| aria-label="dummy-aria-label" | ||
| role="separator" | ||
| className="custom-class"> | ||
| <SwitcherItem | ||
| role="separator" | ||
| aria-label="test-aria-label-switcheritem" | ||
| aria-valuenow={'100'}> | ||
| Dummy child | ||
| </SwitcherItem> | ||
| </Switcher> | ||
| <SwitcherDivider role="separator" className="custom-class" /> | ||
| <Switcher role="separator" aria-label="dummy-aria-label"> | ||
| <SwitcherItem | ||
| role="separator" | ||
| aria-label="test-aria-label-switcheritem1" | ||
| aria-valuenow={'100'}> | ||
| Dummy child1 | ||
| </SwitcherItem> | ||
| </Switcher> | ||
| <SwitcherDivider role="separator" data-testid="test-id" /> | ||
| <StoryContent /> | ||
| </> | ||
| ); | ||
|
|
||
| SwitcherItems.storyName = 'Switcher'; |
There was a problem hiding this comment.
We can delete this as these components are already used in other stories, like HeaderWActionsAndSwitcher
There was a problem hiding this comment.
Deleted SwitcherItems as per review commendt
tay1orjones
reviewed
Nov 6, 2023
alisonjoseph
approved these changes
Nov 15, 2023
alisonjoseph
added
status: ready to merge 🎉
and removed
status: one more review 👀
labels
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
Merged
via the queue into
carbon-design-system:main
with commit Nov 27, 2023
a640108
18 checks passed
danoro96
pushed a commit
to danoro96/carbon
that referenced
this pull request
Jan 18, 2024
…n-design-system#13584 (carbon-design-system#14989) * fix(react): convert js to typescript carbon-design-system#13584 * fix(react): js -> ts -SwitcherItem ,Divider carbon-design-system#13584 * fix(code): tests, proptype description carbon-design-system#13584 * fix(code): warning carbon-design-system#13584 * fix(code): deleted from storybook as per review * fix(react): incorporate feedback --------- Co-authored-by: Andrea N. Cardona <cardona.n.andrea@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #13584
Add TypeScript types to Switcher, SwitcherDivider, SwitcherItem
Changelog
New
Changed
Removed
Testing / Reviewing
executed lint, run test suite and ensured no new failures after the commit, Added these component in UIShell storybook and verified.