fix: adds arrow keys navigation functionality in the Switcher, and increases test coverage #18115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for v11-carbon-web-components ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for v11-carbon-react ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for v11-carbon-react ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #18115 +/- ##
==========================================
+ Coverage 83.22% 83.36% +0.13%
==========================================
Files 404 404
Lines 14338 14344 +6
Branches 4645 4646 +1
==========================================
+ Hits 11933 11958 +25
+ Misses 2243 2224 -19
Partials 162 162 ☔ View full report in Codecov by Sentry. |
2nikhiltom
changed the title
2nikhiltom
added
status: ready for review 👀
and removed
status: WIP 👩💻
DO NOT MERGE
labels
guidari
approved these changes
Nov 21, 2024
|
The content of this pull request will be made available as part of our next release. For the full schedule of upcoming releases, check out our Release Radar page. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #17493
This PR addresses an issue where the Arrow keys navigation functionality in the Switcher component was no longer working after types were added and Increases the test coverage to 100%
The cause for navigation issues was related to a change in the condition for checking the component type
child.type?.displayName === 'SwitcherItem'condition in earlier.jsfile was changed to getDisplayName(child.type) === 'Switcher' when component was converted to.tsxChangelog
New
getDisplayName(curr.type) === 'SwitcherItem' check inenabledIndicesto ensures that only SwitcherItem components are included in the navigationChanged
reverted to
getDisplayName(child.type) === 'SwitcherItem'Testing / Reviewing