fix(Tooltip): add focus trap behavior and fix focus management logic #6458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
emyarod
force-pushed
the
6443-interactive-tooltip-focus-behavior
branch
from
3957aa7
to
62a5688
Compare
|
Deploy preview for carbon-elements ready! Built with commit 3957aa7 |
|
Deploy preview for carbon-elements ready! Built with commit cd2d3a7 |
|
Deploy preview for carbon-components-react ready! Built with commit 3957aa7 https://deploy-preview-6458--carbon-components-react.netlify.app |
|
Deploy preview for carbon-components-react ready! Built with commit cd2d3a7 https://deploy-preview-6458--carbon-components-react.netlify.app |
tw15egan
approved these changes
Jul 14, 2020
aledavila
approved these changes
Jul 16, 2020
emyarod
force-pushed
the
6443-interactive-tooltip-focus-behavior
branch
from
5d153a5
to
cd2d3a7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6443
Refs #1264 (comment)
Refs #4414
Refs #5489
This PR implements optional focus trapping in the interactive tooltip and correctly places focus back on the trigger element after the tooltip is dismissed.
Changelog
Changed
wrapFocusprops to be more genericTesting / Reviewing
Confirm that focus and blur behaves as expected within the interactive tooltip component as well as between interactive siblings to the tooltip. Ensure that focus management remains the same in other
wrapFocusorFloatingMenucomponents like Modal, ComposedModal, and OverflowMenu