fix(OverflowMenu): set focusTrap prop on FloatingMenu #6978
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for carbon-elements ready! Built with commit 699c6ca |
|
Deploy preview for carbon-components-react ready! Built without sensitive environment variables with commit 699c6ca https://deploy-preview-6978--carbon-components-react.netlify.app |
aledavila
approved these changes
Oct 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6977
Related #5489 #6458 #6722
This PR sets the
focusTrapprop on the overflow menu's internal FloatingMenu so that browser focus automatically moves into the overflow menu when the menu is opened, fixing a regressionTesting / Reviewing
Confirm that the autofocus behavior of the overflow menu is restored