Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Decision for proposal #42 (Create code review guidelines) #176

Merged
merged 2 commits into from
Oct 16, 2020
Merged

Decision for proposal #42 (Create code review guidelines) #176

merged 2 commits into from
Oct 16, 2020

Conversation

sidney13
Copy link
Contributor

(Note that this PR is a recreation of PR #137 that got stuck in Git merge hell.)

@google-cla google-cla bot added the cla: yes PR meets CLA requirements according to bot. label Oct 16, 2020
@sidney13 sidney13 requested a review from jonmeow October 16, 2020 18:09
@sidney13 sidney13 mentioned this pull request Oct 16, 2020
Closed
@sidney13 sidney13 merged commit c82140a into carbon-language:trunk Oct 16, 2020
@sidney13 sidney13 deleted the code_review_decision_2 branch December 9, 2020 01:34
chandlerc pushed a commit that referenced this pull request Jun 28, 2022
@sidney13
Decision for proposal #42 (Create code review guidelines) (#176)
4e81e25 
* Decision for proposal #42 (Create code review guidelines)

This is a recreation of PR #137 that got stuck in git merge hell.

* Results of running pre-commit
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonmeow jonmeow jonmeow approved these changes

Assignees
No one assigned
Labels
cla: yes PR meets CLA requirements according to bot.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sidney13 @jonmeow