Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decision for proposal #42 (Create code review guidelines) #176

Merged
merged 2 commits into from
Oct 16, 2020
Merged

Decision for proposal #42 (Create code review guidelines) #176

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ae59ef5
Decision for proposal #42 (Create code review guidelines)
sidney13 Oct 16, 2020
ecdf970
Results of running pre-commit
sidney13 Oct 16, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions proposals/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,13 +26,15 @@ request:
- [0029 - Linear, rebase, and pull-request GitHub workflow](p0029.md)
- [Decision](p0029_decision.md)
- [0042 - Create code review guidelines](p0042.md)
- [Decision](p0042_decision.md)
- [0044 - Proposal tracking](p0044.md)
- [Decision](p0044_decision.md)
- [0051 - Goals](p0051.md)
- [Decision](p0051_decision.md)
- [0074 - Change comment/decision timelines in proposal process](p0074.md)
- [Decision](p0074_decision.md)
- [0083 - In-progress design overview](p0083.md)
- [Decision](p0083_decision.md)
- [0107 - Code and name organization](p0107.md)
- [0120 - Add idiomatic code performance and developer-facing docs to goals](p0120.md)
- [Decision](p0120_decision.md)
Expand Down
46 changes: 46 additions & 0 deletions proposals/p0042_decision.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,46 @@
# Decision for: Create code review guidelines

<!--
Part of the Carbon Language project, under the Apache License v2.0 with LLVM
Exceptions. See /LICENSE for license information.
SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
-->

Proposal accepted on 2020-08-03

Affirming:

- [austern](https://github.com/austern)
- [chandlerc](https://github.com/chandlerc)
- [geoffromer](https://github.com/geoffromer)
- [gribozavr](https://github.com/gribozavr)
- [zygoloid](https://github.com/zygoloid)

Abstaining:

- [josh11b](https://github.com/josh11b)
- [noncombatant](https://github.com/noncombatant)
- [tituswinters](https://github.com/tituswinters)

## Open questions

There were no open questions.

## Rationale

This proposal contains the right goals for the code review process in light of
our project goals, and the proposal is well-tailored to achieve them.
Specifically:

- Ensure high quality of code, documentation, and other artifacts. We consider
these all "code reviews" regardless of whether the final artifact is "code"
in a technical sense.
- Encourage broad participation and contribution to the community through code
reviews.
- Ensure code reviews are inclusive, respectful, and welcoming.
- Have clear, discoverable, and mechanically enforced (where possible) rules
for who can, who should, and who must review any particular change.

We want pre-commit rather than post-commit review, and we want all changes to go
through review. These guidelines are consistent with standard code review best
practice, including what’s described in the cited sources.