Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cardano.Wallet.Shelley.Launch.BlockfrostSpec #3176

Merged
merged 4 commits into from
Mar 17, 2022
Merged

Conversation

Unisay
Copy link
Contributor

@Unisay Unisay commented Mar 16, 2022

  • I have changed the code such that --node-socket and --light --blockfrost-token-file options are mutually exclusive;
  • added 2 more unit tests;
Usage: cardano-wallet serve [--listen-address HOST] 
                            (--node-socket FILE | --light
                              --blockfrost-token-file FILE) 
                            [--random-port | --port INT] 
                            [--tls-ca-cert FILE --tls-sv-cert FILE
                              --tls-sv-key FILE] 
                            (--mainnet | --testnet FILE | --staging FILE) 
                            [--database DIR] [--sync-tolerance DURATION] 
                            [--shutdown-handler] 
                            [--pool-metadata-fetching ( none | direct | SMASH-URL )]
                            [--token-metadata-server URL] 
                            [--trace-NAME SEVERITY]
  Serve API that listens for commands/actions.

Issue Number

ADP-1426

Copy link
Contributor

@HeinrichApfelmus HeinrichApfelmus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! 😊 I find no obvious defects.

@Unisay Unisay force-pushed the yura/ADP-1426/test branch from 1bc558f to 7ffb37c Compare March 17, 2022 13:11
@Anviking
Copy link
Member

I think this broke CI (hydra) on master 😶 => #3180

@Unisay I would recommend merging using bors r+/bors merge and not manually. Manual merges used to be disabled, but I think it was enabled recently not to block us in cases where we were struggling to get something merged with bors, but where it was clear that the failures weren't related to our PR.

I see there's no clear mention in the docs however, we should probably add it

@Unisay
Copy link
Contributor Author

Unisay commented Mar 18, 2022

I think this broke CI (hydra) on master no_mouth => #3180

@Unisay I would recommend merging using bors r+/bors merge and not manually. Manual merges used to be disabled, but I think it was enabled recently not to block us in cases where we were struggling to get something merged with bors, but where it was clear that the failures weren't related to our PR.

I see there's no clear mention in the docs however, we should probably add it

Roger wilco!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants